This is only a partial fix though, it basically restores the old behavior as a default. That doesn't help though with flipping the definitions to get stuff out of the UI Locale file though. So that'll have to come next for allowing wildcard resolutions to be done from the game(?) or maybe locale extension files?
GetKeyCode doesn't handle unicode, so it returns 0 for cyrillic (and other) characters, which was getting rejected as invalid input. I'm assuming this broke on some wxWidgets upgrade, as the MSE code for this hasn't changed in over a decade?
This commit is what broke it, but it did so while referencing some cross platform incompatibility. I hope the method done by this fix avoids that compatibility issue.
The display size of the Output image was being computed using the available element size, which included margins and was leading to the bottom couple pixels being clipped. Correcting that to properly account for the actual image size.
This is more backwards compatible and would permit applying this locale to an older version without as much mess. I don't think MSE has any concept of versioning on locales unfortunately to permit declaring which field applies to which version.
MSE draws masks on the slice window and expects the sizes to be equivalent. This was presenting problems with the way I was trying to do internal scale as I was applying the scale upfront as the slice window loads and would need to scale the mask to match. Instead, applying the scale only when the output is generated from the slice window.
This is a workaround, not a good solution. The slice doesn't really handle sizing well and doesn't set great maximum sizes on the elements within it. I _think_ that can be worked around by constraining the preview, but none of that is really properly context aware to the user's screen.
Want to circle back and find a better pattern for this as it enlarges the slice window (which doesn't clamp the preview window) and it unnecessarily upscales small images which bloats storage a bit. There's probably also something smarter to do with just saving "as large as possible" rather than strictly template size.
Will need to propogate these filtering options to the other places these things are present, there's a dedicated variant for just the stylesheet dialog window and also the Style tab.
Brendan Hagan