feat: super sloppy way of adding more card list columns (created, modified, notes)

src/data/card.cpp

@@ -52,6 +52,24 @@ String Card::identification() const {
   }
 }
 
+String Card::valueOfDataKey(FieldP fieldP) {
+    String columnName = fieldP.get()->name;
+
+    if (columnName == "time_created") {
+        return time_created.Format("%Y-%m-%d %H:%M:%S").ToStdString();
+    }
+    else if (columnName == "time_modified") {
+        return time_modified.Format("%Y-%m-%d %H:%M:%S").ToStdString();
+    }
+    else if (columnName == "has_notes") {
+        return notes.empty() ? "N" : "Y";
+    }
+
+    ValueP val = data[fieldP];
+    if (val) return val->toString();
+    else     return wxEmptyString;
+}
+
 bool Card::contains(QuickFilterPart const& query) const {
   FOR_EACH_CONST(v, data) {
     if (query.match(v->fieldP->name, v->toString())) return true;

src/data/card.hpp

@@ -61,6 +61,9 @@ public:
   /// Get the identification of this card, an identification is something like a name, title, etc.
   /** May return "" */
   String identification() const;
+
+  String valueOfDataKey(FieldP fieldP);
+
   /// Does any field contains the given query string?
   bool contains(QuickFilterPart const& query) const;
   

src/gui/control/card_list.cpp

@@ -186,9 +186,17 @@ bool CardListBase::doDelete() {
 // Comparison object for comparing cards
 bool CardListBase::compareItems(void* a, void* b) const {
   FieldP sort_field = column_fields[sort_by_column];
+
   ValueP va = reinterpret_cast<Card*>(a)->data[sort_field];
   ValueP vb = reinterpret_cast<Card*>(b)->data[sort_field];
   assert(va && vb);
+
+  // Super hack for sorting internal fields. Couldn't figure out how to bind these to ValuePs.
+  if (sort_field->name == "time_created" || sort_field->name == "time_modified" || sort_field->name == "has_notes") {
+      int cmp = smart_compare(reinterpret_cast<Card*>(a)->valueOfDataKey(sort_field), reinterpret_cast<Card*>(b)->valueOfDataKey(sort_field));
+      if (cmp != 0) return cmp < 0;
+  }
+
   // compare sort keys
   int cmp = smart_compare( va->getSortKey(), vb->getSortKey() );
   if (cmp != 0) return cmp < 0;
@@ -309,9 +317,8 @@ String CardListBase::OnGetItemText(long pos, long col) const {
     // wx may give us non existing columns!
     return wxEmptyString;
   }
-  ValueP val = getCard(pos)->data[column_fields[col]];
-  if (val) return val->toString();
-  else     return wxEmptyString;
+
+  return getCard(pos)->valueOfDataKey(column_fields[col]);
 }
 
 int CardListBase::OnGetItemImage(long pos) const {