Fixed some gcc warnings

CMakeLists.txt

@@ -48,7 +48,6 @@ target_sources(magicseteditor PRIVATE resource/win32_res.rc)
 
 if(WIN32)
   add_executable(magicseteditor-cli)
-  #set_target_properties(magicseteditor-cli PROPERTIES OUTPUT_NAME "magicseteditor.com")
   target_sources(magicseteditor-cli PRIVATE src/cli/win32_cli_wrapper.cpp)
   add_custom_command(TARGET magicseteditor-cli POST_BUILD COMMAND
     ${CMAKE_COMMAND} -E copy "${PROJECT_BINARY_DIR}/magicseteditor-cli.exe" "${PROJECT_BINARY_DIR}/magicseteditor.com"
@@ -59,7 +58,7 @@ endif()
 # warnings
 if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX)
   # Update if necessary
-  #set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wno-comment")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wno-comment")
 endif()
 
 # visual studio debugger

src/cli/text_io_handler.cpp

@@ -57,7 +57,7 @@ void TextIOHandler::init() {
     // Use console mode if one of the cli flags is passed
     static const Char* redirect_flags[] = {_("-?"),_("--help"),_("-v"),_("--version"),_("--cli"),_("-c"),_("--export"),_("--create-installer")};
     for (int i = 1 ; i < wxTheApp->argc ; ++i) {
-      for (int j = 0 ; j < sizeof(redirect_flags)/sizeof(redirect_flags[0]) ; ++j) {
+      for (size_t j = 0 ; j < sizeof(redirect_flags)/sizeof(redirect_flags[0]) ; ++j) {
         if (String(wxTheApp->argv[i]) == redirect_flags[j]) {
           have_console = true;
           have_stderr = true;

src/gui/new_window.cpp

@@ -51,7 +51,7 @@ NewSetWindow::NewSetWindow(Window* parent)
   game_list->showData<Game>();
   try {
     game_list->select(settings.default_game);
-  } catch (FileNotFoundError e) {
+  } catch (FileNotFoundError const& e) {
     handle_error(e);
   }
   game_list->SetFocus();