move reverse_string to string.hpp

src/script/functions/basic.cpp

@@ -316,14 +316,6 @@ SCRIPT_FUNCTION(to_title) {
   SCRIPT_RETURN(capitalize(input.Lower()));
 }
 
-String reverse_string(String const& input) {
-  // Note: std::reverse doesn't work because of unicode encoding stuff
-  String reversed;
-  for (auto it = input.rbegin(); it != input.rend(); ++it) {
-    reversed += *it;
-  }
-  return reversed;
-}
 // reverse a string
 SCRIPT_FUNCTION(reverse) {
   SCRIPT_PARAM_C(String, input);

src/util/string.cpp

@@ -79,6 +79,15 @@ String replace_all(const String& heystack, const String& needle, const String& r
   return ret;
 }
 
+String reverse_string(String const& input) {
+  // Note: std::reverse doesn't work because of unicode encoding stuff
+  String reversed;
+  for (auto it = input.rbegin(); it != input.rend(); ++it) {
+    reversed += *it;
+  }
+  return reversed;
+}
+
 // ----------------------------------------------------------------------------- : Words
 
 String last_word(const String& s) {

src/util/string.hpp

@@ -132,6 +132,9 @@ String substr_replace(const String& input, size_t start, size_t end, const Strin
 /// Replace all occurences of one needle with replacement
 String replace_all(const String& heystack, const String& needle, const String& replacement);
 
+/// Reverses a string, Note: std::reverse doesn't work with wxString
+String reverse_string(String const& input);
+
 // ----------------------------------------------------------------------------- : Words
 
 /// Returns the last word in a string