amy/MagicSetEditor2
1
0
Fork 0
mirror of https://github.com/amyinspace/MagicSetEditor2.git synced 2026-06-11 13:17:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential crash when there are errors in a statistics script

Browse Source
This commit is contained in:
Twan van Laarhoven
2020-06-01 14:11:40 +02:00
parent 7952a889c9
commit f9d18ac3c8
3 changed files with 22 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gui/set/stats_panel.cpp
+4 -1
View File
@@ -477,7 +477,7 @@ void StatsPanel::showCategory(const GraphType* prefer_layout) {
// find values for each card
for (size_t i = 0 ; i < set->cards.size() ; ++i) {
Context& ctx = set->getContext(set->cards[i]);
GraphElementP e(new GraphElement(i));
GraphElementP e = make_intrusive<GraphElement>(i);
bool show = true;
FOR_EACH(dim, dims) {
try {
@@ -490,9 +490,12 @@ void StatsPanel::showCategory(const GraphType* prefer_layout) {
}
} catch (ScriptError const& e) {
handle_error(ScriptError(e.what() + _("\n in script for statistics dimension '") + dim->name + _("'")));
show = false;
break;
}
}
if (show) {
assert(e->values.size() == dims.size());
d.elements.push_back(e);
}
}