From 386e5ba4a421123b035149ed761ef5f05d5b90d1 Mon Sep 17 00:00:00 2001 From: Brendan Hagan Date: Mon, 4 Jul 2022 01:04:26 -0400 Subject: [PATCH] misc: additional documentation for internal image scale --- src/gui/value/image.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gui/value/image.cpp b/src/gui/value/image.cpp index 94cb9f88..21399a05 100644 --- a/src/gui/value/image.cpp +++ b/src/gui/value/image.cpp @@ -40,9 +40,12 @@ void ImageValueEditor::sliceImage(const Image& image) { GeneratedImage::Options options((int)style().width, (int)style().height, &parent.getStylePackage(), &parent.getLocalPackage()); AlphaMask mask; style().mask.getNoCache(options,mask); - // slice - RealSize desiredSliceSize = RealSize(style().getSize().width * settings.internal_scale, style().getSize().height * settings.internal_scale); - ImageSliceWindow s(wxGetTopLevelParent(&editor()), image, desiredSliceSize, mask); + // slice + // Specify a desired size based on the stylesheet and a scale multiplier defined within the user's settings. + // Storing at a greater than 100% resolution allows for better exports >100%, but may change how images look when filters (sharpen) are applied. + // Additionally, this bloats the set file size as even under-resolution images are upscaled to the new minimum size. + RealSize desired_slice_size = RealSize(style().getSize().width * settings.internal_scale, style().getSize().height * settings.internal_scale); + ImageSliceWindow s(wxGetTopLevelParent(&editor()), image, desired_slice_size, mask); // clicked ok? if (s.ShowModal() == wxID_OK) { // store the image into the set