From 2932d0007d9c764452082a756429b1ebedd0b054 Mon Sep 17 00:00:00 2001
From: GenevensiS <66968533+G-e-n-e-v-e-n-s-i-S@users.noreply.github.com>
Date: Thu, 4 Dec 2025 15:44:04 +0100
Subject: [PATCH] Bulk card modification

---
 resource/tool/card_modify_multiple.png | Bin 0 -> 4622 bytes
 resource/win32_res.rc                  |   1 +
 src/data/action/set.cpp                |  27 ++
 src/data/action/set.hpp                |  30 +++
 src/data/action/value.cpp              |  32 ++-
 src/data/action/value.hpp              |  52 ++--
 src/gui/bulk_modification_window.cpp   | 330 +++++++++++++++++++++++++
 src/gui/bulk_modification_window.hpp   |  48 ++++
 src/gui/control/card_list.cpp          |  12 +-
 src/gui/control/card_list.hpp          |   8 +-
 src/gui/set/cards_panel.cpp            |   4 +
 src/util/window_id.hpp                 |   7 +-
 12 files changed, 527 insertions(+), 24 deletions(-)
 create mode 100644 resource/tool/card_modify_multiple.png
 create mode 100644 src/gui/bulk_modification_window.cpp
 create mode 100644 src/gui/bulk_modification_window.hpp

diff --git a/resource/tool/card_modify_multiple.png b/resource/tool/card_modify_multiple.png
new file mode 100644
index 0000000000000000000000000000000000000000..eb3d9b22b611ec9232fff57526fb5e800f18cf7b
GIT binary patch
literal 4622
zcmeHKeNYo;8sA72MXR92kE-Vq&=GNyO|n^%Jt81M6C@A;75o_4>~3Jqr^!MB*i#X0
zIeSc%ij~7^tF2XAM#Vc7M5TU<?KxUI4x;fC^{Rp>DsV-;cf*G;*O?n<uK$tjX7_zQ
ze(&@Ap67ihZ=pV6_Pc)X`#})&u2!Q?0#ASb9y|#APHK5gf=5kmN-CE`x?sD*W@OC_
z%;ne_m~pd42y)k1^fduKL4!LM#l}I=YaK_+wrG7rBi;5bvhzgwP(|3rGY{J}hYCL~
zJB;mK7&bOF%^4na>tDXX%{2ihLQ7Ws`@I8SolAJCUsfO4GI;%{?Bu(Kkk+YYQ?#<<
zZtc`xqbqjoZbdJnUp^W*Y)z9Vf6wLerPl_1>+fMl*4Dj9tT*T8?RQPRAFWA`PpKA^
zR)sv6Qd+S@opdGBWW+9-;n(*#VYT2In)Y5XTDJ;<1O;qNj9wcP)13@Rq3nYVD$U8L
zvFkiv$Hh+b%l4mpPQUfhmq`=m1g=m2;$YyyEcD2;5v5p2sHiC4R8zC<^qw{AE6RtL
z=fiD2w?&H3N=>0>^4igoo6GA@=6QZ~v`&Pvz47uq!>T=LvxtB(&h~kd=08I}1brMl
zO_H2w99_{oVQFjglb53JD~>*VHNhvYhF+BzQY5*t@1yXKcKo&E$DD17Qx`VQT#*pL
zTpCz7>4>PR<IItUeJ5lwvv5`71mWm8OQyRdVdJMgnZ7)AuKdCnhbXM<kYevu!sIDF
zj;3CkFI~J#zV4lpPt<-w`lq?kfun^7O*=o+T*;|F8Tp_sxnbk^d4k}x1D5H7lz(cD
zY`d|jLLqCMGVo5+<Mo!6@zCle+pq3xd`w-pZiQZD+=_eHX40iM6+fFbd*~#=n(HS{
zXU#5dT~#|Vy+ONq*!c||2MY`V?#Las3qB_gMZGS)e&~fVVbZGU&zH3iQYhY;GUwCk
zrYB9unvT6(bfw8NqAuQXDQfNWqoC=sS<qamx_E-JSwtjlGcY2z#SXd-f+9c{k(7zy
zU;~rET2;cwRmX)eORIzn<T_Mmk6|)dO|FAU&P_<6a!r(y7DmqSi*OSFz`}4O?6#P#
zPQtAcdT|Nx&WpuD*lWU>RKir99*(g&7#I^_A{2>rv)NMN3_m!+K^uuA^{g%kFj5IK
zInGXq#V(gi<dTVOjtsFxsZ@$lsaPsSfCb{rv2vsvu{wi!h)xVO<D?v{onviQn8zdy
zwk%F16aqcm9iPRn)Ahhxon0&dKE!U)E|!Q;vBe_p?cwBNvjIp~K)>nXOaW_DoWwY7
zSq_Sc&1S4zaBm2j>hZT{In3U4XiChO84ECVf>|Yfrkt(S>3ckQ3Nl!W-RlL&?qkWZ
z#y4d3iH+BI)9D=uaPPtGW8Iy**BDsobcEVQW%1!@)hZ!BKSA3lmL|Nf5(ZV$jNFJA
zPz*&d95*7QTuCFCoRmssC?>^8LoX<;)ya`ois7LExQGQfQi)uOp%My_Q51z>j8cvm
z7&(r}XqiMIBXLTpko1B`bg-Z+NptV0cqke`84L!RmID+ejRGiKfguVhra%~@QHmMl
z6ef{My-+ko%(6KwBq%3qAu|}U-J0Q5@Prf5daX(*6`^k=dNauxfdg0rtd+L8oNrVq
ztc6MDNS;qgxLl${6;fP@<5;)?dt)@8aX3LQ@~9G2B*VQLzAywx2T)7$oeBWFa*z!X
z<6ub6=18&G%qk%t6wG_}sC8gL(IiKzNsa-as8mj%;owS<C<%##K$T&rlt6pg+i2F9
z^S`Y5<pW1_7G1+S!TdR1QRkXUW|nu3I)`S~yO?0uyDSKj>P*2&W;3)mPJq>^qB2Qq
z1_Snwu7>TFv%k>{BpR-yNJ@&(7-m2)62(Ag;S54yC?z3r98{9&i|(`;ITz_*qB8)G
zfGg0TUasJ&U8M@`YwyZr_&NZ}5HuWIJ(LN>UCE019iuzj2=RaM5#crHwZ#CxP8ry`
zz)mRc*$TV(;y0b&@zYg@-*E;2-9O1&@!L;VKV5Idz*`yjcUM1MZ^gh{8TWVB|BWuc
zH-{<43jP7Pz)|Van(J-gm^H{SXSN!8&40I7?<xk8A$Cog6M}}0;%@;|S~eC4eL1Zz
z*7p}*-+-Y*=I#8}1kTb&wd&{;MeU~I$jnjX*fT3PFK$XYK7sYQ5C1HztBH;KTSAb6
z%iawq)WqI4p9@(xbmGP3dNsPGAU-Ykmhjc}0}p@B_upI+KW@N+V|67BGd?UeEfX2G
zJ<0Rj&)L@c(w#n_@rTLJJ2rfG7<x8;Z(u<F)-l6AMBDK~!~Sn{L!fIeb9Q8-LBPiB
z@H{@7&=Qd-__X$}Mq{#xcEf`Oicf-ziUQNZR&R)dnv2iM8mr3p{_@AjB86g@cKrJ#
z8pn!}mv4;!ygcNeSF7?+XwdfIt9KS&mYF|jb60-<w6gX=T**I{R()2DROZFtH}SR~
zO;3aM)!_x6%ip}5zPNJT$Z&1>jlV1ofew!Hfe%=G+5;9hPX7Ab7l()E-s=cx&-(iU
zI4C@S?YM?ln`#^GU2GYC>NW!5f57+IB3BD!=c`ZW?9^;kqA!*{{VKp9c!k$PHxJd#
zJ-Mbsb_v;-yRN>hFf{4h#ex%UV{ZFv+zXFSTGVoOK<z`(+L;1RYv`u9pO(oVJSU3o
z?1L0Vve@$Zdsj|;GNQnLzwY(L0a3fI2%_S~1>T-=mKf`MswLv885ciFpSEOE+}-1M
d9#xjV7+-U2*X9U3Yz!zZq>W8bm(NVk{|~V$vTy(Z

literal 0
HcmV?d00001

diff --git a/resource/win32_res.rc b/resource/win32_res.rc
index 4d052b5c..21d8b6bd 100644
--- a/resource/win32_res.rc
+++ b/resource/win32_res.rc
@@ -55,6 +55,7 @@ tool/no_auto IMAGE "tool/no_auto.png"
 
 tool/card_add IMAGE "tool/card_add.png"
 tool/card_add_multiple IMAGE "tool/card_add_multiple.png"
+tool/card_modify_multiple IMAGE "tool/card_modify_multiple.png"
 tool/card_del IMAGE "tool/card_del.png"
 tool/card_link IMAGE "tool/card_link.png"
 tool/card_copy IMAGE "tool/card_copy.png"
diff --git a/src/data/action/set.cpp b/src/data/action/set.cpp
index 8f445e87..a5470368 100644
--- a/src/data/action/set.cpp
+++ b/src/data/action/set.cpp
@@ -212,7 +212,34 @@ String ChangeCardHasStylingAction::getName(bool to_undo) const {
 void ChangeCardHasStylingAction::perform(bool to_undo) {
   card->has_styling = !card->has_styling;
   swap(card->styling_data, styling_data);
+}
+
+// ----------------------------------------------------------------------------- : Change notes
+
+ChangeCardNotesAction::ChangeCardNotesAction(const CardP& card, const String& notes)
+  : card(card), notes(notes)
+{}
+String ChangeCardNotesAction::getName(bool to_undo) const {
+  return _("Change notes");
 }
+void ChangeCardNotesAction::perform(bool to_undo) {
+  swap(card->notes, notes);
+}
+
+// ----------------------------------------------------------------------------- : Change uid
+
+ChangeCardUIDAction::ChangeCardUIDAction(Set& set, const CardP& card, const String& uid)
+  : CardListAction(set), card(card), uid(uid)
+{}
+String ChangeCardUIDAction::getName(bool to_undo) const {
+  return _("Change ID");
+}
+void ChangeCardUIDAction::perform(bool to_undo) {
+  FOR_EACH(c, set.cards) {
+    c->updateLink(card->uid, uid);
+  }
+  swap(card->uid, uid);
+}
 
 // ----------------------------------------------------------------------------- : Pack types
 
diff --git a/src/data/action/set.hpp b/src/data/action/set.hpp
index 9e43864c..d8156466 100644
--- a/src/data/action/set.hpp
+++ b/src/data/action/set.hpp
@@ -147,8 +147,38 @@ public:
   Set&                    set;          ///< The set to copy styling from
   CardP                   card;         ///< The affected card
   IndexMap<FieldP,ValueP> styling_data; ///< The old styling of the card
+};
+
+// ----------------------------------------------------------------------------- : Change notes
+
+/// Changing the notes of a card
+class ChangeCardNotesAction : public Action {
+public:
+  ChangeCardNotesAction(const CardP& card, const String& notes);
+
+  String getName(bool to_undo) const override;
+  void perform(bool to_undo) override;
+
+  //private:
+  CardP  card;  ///< The affected card
+  String notes; ///< Its old notes
 };
 
+// ----------------------------------------------------------------------------- : Change uid
+
+/// Changing the uid of a card
+class ChangeCardUIDAction : public CardListAction {
+public:
+  ChangeCardUIDAction(Set& set, const CardP& card, const String& id);
+
+  String getName(bool to_undo) const override;
+  void perform(bool to_undo) override;
+
+  //private:
+  CardP  card; ///< The affected card
+  String uid;  ///< Its old uid
+};
+
 // ----------------------------------------------------------------------------- : Pack types
 
 /// An Action the changes the pack types of a set
diff --git a/src/data/action/value.cpp b/src/data/action/value.cpp
index 2cd5bb55..888bdf5a 100644
--- a/src/data/action/value.cpp
+++ b/src/data/action/value.cpp
@@ -36,7 +36,10 @@ void ValueAction::setCard(CardP const& card) {
 }
 
 // ----------------------------------------------------------------------------- : Simple
-
+
+unique_ptr<ValueAction> value_action(const TextValueP& value, const Defaultable<String>& new_value) {
+  return make_unique<SimpleValueAction<TextValue, false>>(value, new_value);
+}
 unique_ptr<ValueAction> value_action(const ChoiceValueP& value, const Defaultable<String>& new_value) {
   return make_unique<SimpleValueAction<ChoiceValue, true>>(value, new_value);
 }
@@ -205,7 +208,34 @@ String ScriptStyleEvent::getName(bool) const {
 }
 void ScriptStyleEvent::perform(bool) {
   assert(false); // this action is just an event, it should not be performed
+}
+
+// ----------------------------------------------------------------------------- : Bulk action
+
+BulkAction::BulkAction(const vector<shared_ptr<Action>>& actions, const SetP& set, CardListBase* card_list_window)
+  : actions(actions), set(set), card_list_window(card_list_window)
+{
+  if (actions.empty()) throw InternalError(_("BulkAction created with no actions"));
+  name_do = actions.front()->getName(false) + _(" ") + _ACTION_("bulk");
+  name_undo = actions.front()->getName(true) + _(" ") + _ACTION_("bulk");
 }
+BulkAction::~BulkAction() {}
+
+String BulkAction::getName(bool to_undo) const {
+  return to_undo ? name_undo : name_do;
+}
+
+void BulkAction::perform(bool to_undo) {
+  FOR_EACH(action, actions) {
+    action->perform(to_undo);
+    set->actions.tellListeners(*action, to_undo);
+  }
+  card_list_window->Refresh();
+}
+
+bool BulkAction::merge(const Action& action) {
+  return false;
+}
 
 // ----------------------------------------------------------------------------- : Action performer
 
diff --git a/src/data/action/value.hpp b/src/data/action/value.hpp
index 3a5c736f..f7ba1606 100644
--- a/src/data/action/value.hpp
+++ b/src/data/action/value.hpp
@@ -23,6 +23,7 @@
 #include <data/field/image.hpp>
 #include <data/field/symbol.hpp>
 #include <data/field/package_choice.hpp>
+#include <gui/control/card_list.hpp>
 
 class StyleSheet;
 class LocalFileName;
@@ -30,15 +31,8 @@ DECLARE_POINTER_TYPE(Card);
 DECLARE_POINTER_TYPE(Set);
 DECLARE_POINTER_TYPE(Value);
 DECLARE_POINTER_TYPE(Style);
-DECLARE_POINTER_TYPE(TextValue);
-DECLARE_POINTER_TYPE(ChoiceValue);
-DECLARE_POINTER_TYPE(MultipleChoiceValue);
-DECLARE_POINTER_TYPE(ColorValue);
-DECLARE_POINTER_TYPE(ImageValue);
-DECLARE_POINTER_TYPE(SymbolValue);
-DECLARE_POINTER_TYPE(PackageChoiceValue);
 
-// ----------------------------------------------------------------------------- : ValueAction (based class)
+// ----------------------------------------------------------------------------- : ValueAction (base class)
 
 /// An Action the changes a Value
 class ValueAction : public Action {
@@ -72,6 +66,15 @@ inline void swap_value(MultipleChoiceValue& a, MultipleChoiceValue::ValueType& b
   swap(a.last_change, b.last_change);
 }
 
+/// Action that updates a Value to a new value
+unique_ptr<ValueAction> value_action(const TextValueP&           value, const Defaultable<String>& new_value);
+unique_ptr<ValueAction> value_action(const ChoiceValueP&         value, const Defaultable<String>& new_value);
+unique_ptr<ValueAction> value_action(const MultipleChoiceValueP& value, const Defaultable<String>& new_value, const String& last_change);
+unique_ptr<ValueAction> value_action(const ColorValueP&          value, const Defaultable<Color>&  new_value);
+unique_ptr<ValueAction> value_action(const ImageValueP&          value, const LocalFileName&       new_value);
+unique_ptr<ValueAction> value_action(const SymbolValueP&         value, const LocalFileName&       new_value);
+unique_ptr<ValueAction> value_action(const PackageChoiceValueP&  value, const String&              new_value);
+
 /// A ValueAction that swaps between old and new values
 template <typename T, bool ALLOW_MERGE>
 class SimpleValueAction : public ValueAction {
@@ -79,13 +82,13 @@ public:
   inline SimpleValueAction(const intrusive_ptr<T>& value, const typename T::ValueType& new_value)
     : ValueAction(value), new_value(new_value)
   {}
-  
+
   void perform(bool to_undo) override {
     ValueAction::perform(to_undo);
     swap_value(static_cast<T&>(*valueP), new_value);
     valueP->onAction(*this, to_undo); // notify value
   }
-  
+
   bool merge(const Action& action) override {
     if (!ALLOW_MERGE) return false;
     TYPE_CASE(action, SimpleValueAction) {
@@ -97,18 +100,10 @@ public:
     }
     return false;
   }
-  
+
   typename T::ValueType new_value;
 };
 
-/// Action that updates a Value to a new value
-unique_ptr<ValueAction> value_action(const ChoiceValueP&         value, const Defaultable<String>& new_value);
-unique_ptr<ValueAction> value_action(const MultipleChoiceValueP& value, const Defaultable<String>& new_value, const String& last_change);
-unique_ptr<ValueAction> value_action(const ColorValueP&          value, const Defaultable<Color>&  new_value);
-unique_ptr<ValueAction> value_action(const ImageValueP&          value, const LocalFileName&       new_value);
-unique_ptr<ValueAction> value_action(const SymbolValueP&         value, const LocalFileName&       new_value);
-unique_ptr<ValueAction> value_action(const PackageChoiceValueP&  value, const String&              new_value);
-
 // ----------------------------------------------------------------------------- : Text
 
 /// An action that changes a TextValue
@@ -206,6 +201,25 @@ public:
   const Style*      style;      ///< The modified style
 };
 
+// ----------------------------------------------------------------------------- : Bulk action
+
+// An action that's just a list of other actions
+class BulkAction : public Action {
+public:
+  BulkAction(const vector<shared_ptr<Action>>& actions, const SetP& set, CardListBase* card_list_window);
+  ~BulkAction() override;
+
+  String getName(bool to_undo) const override;
+  void perform(bool to_undo) override;
+  bool merge(const Action& action) override;
+
+private:
+  String name_do;
+  String name_undo;
+  vector<shared_ptr<Action>> actions;
+  SetP set;
+  CardListBase* card_list_window;
+};
 
 // ----------------------------------------------------------------------------- : Action performer
 
diff --git a/src/gui/bulk_modification_window.cpp b/src/gui/bulk_modification_window.cpp
new file mode 100644
index 00000000..edeb71d4
--- /dev/null
+++ b/src/gui/bulk_modification_window.cpp
@@ -0,0 +1,330 @@
+//+----------------------------------------------------------------------------+
+//| Description:  Magic Set Editor - Program to make Magic (tm) cards          |
+//| Copyright:    (C) Twan van Laarhoven and the other MSE developers          |
+//| License:      GNU General Public License 2 or later (see file COPYING)     |
+//+----------------------------------------------------------------------------+
+
+// ----------------------------------------------------------------------------- : Includes
+
+#include <fstream>
+#include <sstream>
+#include <regex>
+#include <util/prec.hpp>
+#include <data/game.hpp>
+#include <data/set.hpp>
+#include <data/card.hpp>
+#include <data/stylesheet.hpp>
+#include <data/field/multiple_choice.hpp>
+#include <data/field/symbol.hpp>
+#include <data/action/set.hpp>
+#include <data/action/value.hpp>
+#include <script/functions/construction_helper.hpp>
+#include <gui/bulk_modification_window.hpp>
+#include <gui/control/card_list.hpp>
+#include <util/window_id.hpp>
+#include <wx/statline.h>
+
+// ----------------------------------------------------------------------------- : AddCSV
+
+BulkModificationWindow::BulkModificationWindow(Window* parent, const SetP& set, bool sizer)
+  : wxDialog(parent, wxID_ANY, _TITLE_("bulk modify"), wxDefaultPosition, wxDefaultSize, wxDEFAULT_DIALOG_STYLE | wxRESIZE_BORDER)
+  , set(set), parent(parent)
+{
+  // init controls
+  ok_button = new wxButton(this, wxID_OK);
+  predicate_description = new wxStaticText(this, -1, _LABEL_("bulk modify predicate description"));
+  predicate = new wxTextCtrl(this, ID_CARD_BULK_PREDICATE, wxEmptyString, wxDefaultPosition, wxSize(400, 70), wxTE_MULTILINE);
+  predicate->SetHint(_LABEL_("bulk modify predicate example") + _("\ncard.cmc <= 3 and contains(card.type, match:\"Creature\")"));
+  predicate_errors = new wxStaticText(this, wxID_ANY, _(""));
+  predicate_errors->SetForegroundColour(*wxRED);
+  modification_description = new wxStaticText(this, -1, _LABEL_("bulk modify mod description"));
+  modification = new wxTextCtrl(this, ID_CARD_BULK_MODIFICATION, wxEmptyString, wxDefaultPosition, wxSize(400, 70), wxTE_MULTILINE);
+  modification_errors = new wxStaticText(this, wxID_ANY, _(""));
+  modification_errors->SetForegroundColour(*wxRED);
+  modification_parsed = true;
+  modification_selection = new wxChoice(this, ID_CARD_BULK_TYPE, wxDefaultPosition, wxDefaultSize, 0, nullptr);
+  modification_selection->Clear();
+  modification_selection->Append(_LABEL_("bulk modify all"));
+  modification_selection->Append(_LABEL_("bulk modify filtered"));
+  modification_selection->Append(_LABEL_("bulk modify selected"));
+  modification_selection->Append(_LABEL_("bulk modify predicate"));
+  modification_selection->SetSelection(0);
+  changeSelection();
+  parseModification();
+  field_type = new wxChoice(this, ID_CARD_BULK_FIELD, wxDefaultPosition, wxDefaultSize, 0, nullptr, wxCB_SORT);
+  field_type->Clear();
+  String default_selection = _("");
+  field_type->Append(_("id"));
+  field_type->Append(_("stylesheet"));
+  field_type->Append(_("notes"));
+  FOR_EACH(field, set->game->card_fields) {
+    field_type->Append(field->name);
+    if (field->identifying) default_selection = field->name;
+  }
+  int default_index = field_type->FindString(default_selection);
+  if (default_index == wxNOT_FOUND) default_index = 0;
+  field_type->SetSelection(default_index);
+  // init sizers
+  if (sizer) {
+    wxSizer* s = new wxBoxSizer(wxVERTICAL);
+    s->Add(new wxStaticText(this, -1, _LABEL_("bulk modify selection")), 0, wxALL, 8);
+    s->Add(modification_selection, 0, wxEXPAND | (wxALL & ~wxTOP), 8);
+    s->Add(predicate_description, 0, wxEXPAND | wxALL, 8);
+    s->Add(predicate, 0, wxEXPAND | (wxALL & ~wxTOP), 8);
+    s->Add(predicate_errors, 0, wxALL & ~wxTOP, 8);
+    s->AddSpacer(20);
+    s->Add(new wxStaticText(this, -1, _LABEL_("bulk modify field")), 0, wxALL, 8);
+    s->Add(field_type, 0, wxEXPAND | (wxALL & ~wxTOP), 8);
+    s->Add(modification_description, 0, wxEXPAND | wxALL, 8);
+    s->Add(modification, 0, wxEXPAND | (wxALL & ~wxTOP), 8);
+    s->Add(modification_errors, 0, wxALL & ~wxTOP, 8);
+    s->AddStretchSpacer(1);
+    wxStdDialogButtonSizer* s1 = new wxStdDialogButtonSizer();
+    s1->AddStretchSpacer(1);
+    s1->AddButton(ok_button);
+    s1->AddButton(new wxButton(this, wxID_CANCEL));
+    s1->Realize();
+    s->Add(s1, 1, wxEXPAND | wxALL, 12);
+    s->SetSizeHints(this);
+    SetSizer(s);
+    SetSize(600, 400);
+    Layout();
+  }
+}
+
+void BulkModificationWindow::updateOkButton() {
+  if (predicate_parsed && modification_parsed) {
+    ok_button->Enable(true);
+  }
+  else {
+    ok_button->Enable(false);
+  }
+}
+
+void BulkModificationWindow::changeSelection() {
+  if (modification_selection->GetSelection() <= 2) {
+    predicate_description->Hide();
+    predicate->Hide();
+    predicate_errors->Hide();
+    predicate_parsed = true;
+    SetSize(600, 400);
+  } else {
+    predicate_description->Show();
+    predicate->Show();
+    predicate_errors->Show();
+    parsePredicate();
+    SetSize(600, 560);
+  }
+  updateOkButton();
+  Layout();
+}
+
+void BulkModificationWindow::onSelectionChange(wxCommandEvent&) {
+  changeSelection();
+}
+
+void BulkModificationWindow::parsePredicate() {
+  vector<ScriptParseError> parse_errors;
+  String value = predicate->GetValue();
+  if (value.StartsWith("{") && value.EndsWith("}")) value = value.substr(1, value.length()-2);
+  predicate_script = parse(value, nullptr, false, parse_errors);
+  if (parse_errors.empty()) {
+    predicate_errors->SetLabel(_(""));
+    predicate_parsed = true;
+  }
+  else {
+    predicate_errors->SetLabel(ScriptParseErrors(parse_errors).what());
+    predicate_parsed = false;
+  }
+  updateOkButton();
+}
+
+void BulkModificationWindow::onPredicateChange(wxCommandEvent&) {
+  parsePredicate();
+}
+
+void BulkModificationWindow::parseModification() {
+  vector<ScriptParseError> parse_errors;
+  modification_script = parse(modification->GetValue(), nullptr, true, parse_errors);
+  if (parse_errors.empty()) {
+    modification_errors->SetLabel(_(""));
+    modification_parsed = true;
+  }
+  else {
+    modification_errors->SetLabel(ScriptParseErrors(parse_errors).what());
+    modification_parsed = false;
+  }
+  updateOkButton();
+}
+
+void BulkModificationWindow::onModificationChange(wxCommandEvent&) {
+  parseModification();
+}
+
+void BulkModificationWindow::onOk(wxCommandEvent&) {
+  wxBusyCursor wait;
+  // get the context
+  CardListBase* card_list_window = dynamic_cast<CardListBase*>(parent);
+  if (!card_list_window) {
+    queue_message(MESSAGE_ERROR, _("Bulk modification must be called from a card list window!"));
+    EndModal(wxID_ABORT);
+    return;
+  }
+  // get the cards
+  vector<CardP> cards;
+  int selection_type = modification_selection->GetSelection();
+  if (selection_type == 0) { // all
+    for (int i = 0; i < set->cards.size(); ++i) {
+      cards.push_back(set->cards[i]);
+    }
+  } else if (selection_type == 1) { // currently filtered
+    for (int i = 0; i < card_list_window->GetItemCount(); ++i) {
+      cards.push_back(card_list_window->getCard(i));
+    }
+  } else if (selection_type == 2) { // currently selected
+    card_list_window->getSelection(cards);
+  } else { // predicate
+    FOR_EACH(card, set->cards) {
+      Context& ctx = set->getContext(card);
+      ScriptValueP result = predicate_script->eval(ctx, false);
+      if (result->type() != SCRIPT_BOOL) {
+        queue_message(MESSAGE_ERROR, _ERROR_("bulk modify predicate is not bool"));
+        EndModal(wxID_ABORT);
+        return;
+      }
+      if (result->toBool()) {
+        cards.push_back(card);
+      }
+    }
+  }
+  int count = cards.size();
+  if (count == 0) {
+    queue_message(MESSAGE_ERROR, _ERROR_("bulk modify no cards"));
+    EndModal(wxID_ABORT);
+    return;
+  }
+  // get the new script values
+  vector<shared_ptr<Action>> actions;
+  String& field_name = field_type->GetString(field_type->GetSelection());
+  // stylesheet, notes or id change
+  if (field_name == _("stylesheet") || field_name == _("notes") || field_name == _("id")) {
+    vector<String> new_values;
+    FOR_EACH(card, cards) {
+      Context& ctx = set->getContext(card);
+      ScriptValueP new_value = modification_script->eval(ctx, false);
+      if (new_value->type() != SCRIPT_STRING) {
+        queue_message(MESSAGE_ERROR, _ERROR_("bulk modify mod is not string"));
+        EndModal(wxID_ABORT);
+        return;
+      }
+      new_values.push_back(new_value->toString());
+    }
+    assert(count == new_values.size());
+    if (field_name == _("stylesheet")) {
+      for (int i = 0; i < count; ++i) {
+        StyleSheetP stylesheet = StyleSheet::byGameAndName(*set->game, new_values[i]);
+        actions.push_back(make_shared<ChangeCardStyleAction>(cards[i], stylesheet));
+      }
+    } else if (field_name == _("notes")) {
+      for (int i = 0; i < count; ++i) {
+        actions.push_back(make_shared<ChangeCardNotesAction>(cards[i], new_values[i]));
+      }
+    } else if (field_name == _("id")) {
+      for (int i = 0; i < count; ++i) {
+        actions.push_back(make_shared<ChangeCardUIDAction>(*set, cards[i], new_values[i]));
+      }
+    }
+  }
+  // card field value change
+  else {
+    vector<Value*> values;
+    vector<ScriptValueP> new_values;
+    FOR_EACH(card, cards) {
+      Value* value = get_card_field_container(*set->game, card->data, field_name, false);
+      values.push_back(value);
+      Context& ctx = set->getContext(card);
+      ScriptValueP new_value = modification_script->eval(ctx, false);
+      new_values.push_back(new_value);
+    }
+    assert(count == values.size());
+    assert(count == new_values.size());
+    // make the modifications (I have lost my battle with c++ templates)
+    if (dynamic_cast<TextValue*>(values.front())) {
+      for (int i = 0; i < count; ++i) {
+        TextValue* value = dynamic_cast<TextValue*>(values[i]);
+        TextValue::ValueType new_value = new_values[i]->toString();
+        shared_ptr<SimpleValueAction<TextValue, false>> action = make_shared<SimpleValueAction<TextValue, false>>(value, new_value);
+        action->setCard(cards[i]);
+        actions.push_back(action);
+      }
+    }
+    else if (dynamic_cast<MultipleChoiceValue*>(values.front())) {
+      for (int i = 0; i < count; ++i) {
+        MultipleChoiceValue* value = dynamic_cast<MultipleChoiceValue*>(values[i]);
+        MultipleChoiceValue::ValueType new_value = { new_values[i]->toString(), _("") };
+        shared_ptr<SimpleValueAction<MultipleChoiceValue, false>> action = make_shared<SimpleValueAction<MultipleChoiceValue, false>>(value, new_value);
+        action->setCard(cards[i]);
+        actions.push_back(action);
+      }
+    }
+    else if (dynamic_cast<ChoiceValue*>(values.front())) {
+      for (int i = 0; i < count; ++i) {
+        ChoiceValue* value = dynamic_cast<ChoiceValue*>(values[i]);
+        ChoiceValue::ValueType new_value = new_values[i]->toString();
+        shared_ptr<SimpleValueAction<ChoiceValue, false>> action = make_shared<SimpleValueAction<ChoiceValue, false>>(value, new_value);
+        action->setCard(cards[i]);
+        actions.push_back(action);
+      }
+    }
+    else if (dynamic_cast<PackageChoiceValue*>(values.front())) {
+      for (int i = 0; i < count; ++i) {
+        PackageChoiceValue* value = dynamic_cast<PackageChoiceValue*>(values[i]);
+        PackageChoiceValue::ValueType new_value = new_values[i]->toString();
+        shared_ptr<SimpleValueAction<PackageChoiceValue, false>> action = make_shared<SimpleValueAction<PackageChoiceValue, false>>(value, new_value);
+        action->setCard(cards[i]);
+        actions.push_back(action);
+      }
+    }
+    else if (dynamic_cast<ColorValue*>(values.front())) {
+      for (int i = 0; i < count; ++i) {
+        ColorValue* value = dynamic_cast<ColorValue*>(values[i]);
+        ColorValue::ValueType new_value = new_values[i]->toColor();
+        shared_ptr<SimpleValueAction<ColorValue, false>> action = make_shared<SimpleValueAction<ColorValue, false>>(value, new_value);
+        action->setCard(cards[i]);
+        actions.push_back(action);
+      }
+    }
+    else if (dynamic_cast<ImageValue*>(values.front())) {
+      for (int i = 0; i < count; ++i) {
+        ImageValue* value = dynamic_cast<ImageValue*>(values[i]);
+        wxFileName fname(static_cast<ExternalImage*>(new_values[i].get())->toString());
+        ImageValue::ValueType new_value = LocalFileName::fromReadString(fname.GetName(), "");
+        shared_ptr<SimpleValueAction<ImageValue, false>> action = make_shared<SimpleValueAction<ImageValue, false>>(value, new_value);
+        action->setCard(cards[i]);
+        actions.push_back(action);
+      }
+    }
+    else if (dynamic_cast<SymbolValue*>(values.front())) {
+      for (int i = 0; i < count; ++i) {
+        SymbolValue* value = dynamic_cast<SymbolValue*>(values[i]);
+        wxFileName fname(static_cast<ExternalImage*>(new_values[i].get())->toString());
+        SymbolValue::ValueType new_value = LocalFileName::fromReadString(fname.GetName(), "");
+        shared_ptr<SimpleValueAction<SymbolValue, false>> action = make_shared<SimpleValueAction<SymbolValue, false>>(value, new_value);
+        action->setCard(cards[i]);
+        actions.push_back(action);
+      }
+    }
+    else {
+      queue_message(MESSAGE_ERROR, _ERROR_("bulk modify script type unknown"));
+    }
+  }
+  set->actions.addAction(make_unique<BulkAction>(actions, set, card_list_window), false);
+  EndModal(wxID_OK);
+}
+
+BEGIN_EVENT_TABLE(BulkModificationWindow, wxDialog)
+EVT_BUTTON (wxID_OK,                   BulkModificationWindow::onOk)
+EVT_CHOICE (ID_CARD_BULK_TYPE,         BulkModificationWindow::onSelectionChange)
+EVT_TEXT   (ID_CARD_BULK_PREDICATE,    BulkModificationWindow::onPredicateChange)
+EVT_TEXT   (ID_CARD_BULK_MODIFICATION, BulkModificationWindow::onModificationChange)
+END_EVENT_TABLE()
diff --git a/src/gui/bulk_modification_window.hpp b/src/gui/bulk_modification_window.hpp
new file mode 100644
index 00000000..3843a4fa
--- /dev/null
+++ b/src/gui/bulk_modification_window.hpp
@@ -0,0 +1,48 @@
+//+----------------------------------------------------------------------------+
+//| Description:  Magic Set Editor - Program to make Magic (tm) cards          |
+//| Copyright:    (C) Twan van Laarhoven and the other MSE developers          |
+//| License:      GNU General Public License 2 or later (see file COPYING)     |
+//+----------------------------------------------------------------------------+
+
+#pragma once
+
+// ----------------------------------------------------------------------------- : Includes
+
+#include <util/prec.hpp>
+
+DECLARE_POINTER_TYPE(Game);
+DECLARE_POINTER_TYPE(Set);
+
+// ----------------------------------------------------------------------------- : BulkModificationWindow
+
+/// A window for modifying multiple cards at once.
+class BulkModificationWindow : public wxDialog {
+public:
+  BulkModificationWindow(Window* parent, const SetP& set, bool sizer);
+
+protected:
+  DECLARE_EVENT_TABLE();
+
+  wxChoice*       modification_selection, *field_type;
+  wxStaticText*   modification_description, *modification_errors, *predicate_description, *predicate_errors;
+  wxTextCtrl*     modification, *predicate;
+  bool            modification_parsed, predicate_parsed;
+  wxButton*       ok_button;
+  SetP            set;
+  Window*         parent;
+  ScriptP         modification_script, predicate_script;
+
+  void onSelectionChange(wxCommandEvent&);
+  void changeSelection();
+
+  void onPredicateChange(wxCommandEvent&);
+  void parsePredicate();
+
+  void onModificationChange(wxCommandEvent&);
+  void parseModification();
+
+  void updateOkButton();
+
+  void onOk(wxCommandEvent&);
+
+};
diff --git a/src/gui/control/card_list.cpp b/src/gui/control/card_list.cpp
index 2af3ae63..8ae5c586 100644
--- a/src/gui/control/card_list.cpp
+++ b/src/gui/control/card_list.cpp
@@ -16,6 +16,7 @@
 #include <gui/util.hpp>
 #include <gui/add_csv_window.hpp>
 #include <gui/add_json_window.hpp>
+#include <gui/bulk_modification_window.hpp>
 #include <data/game.hpp>
 #include <data/field.hpp>
 #include <data/field/choice.hpp>
@@ -230,7 +231,16 @@ bool CardListBase::doAddJSON() {
     return true;
   }
   return false;
-}
+}
+
+bool CardListBase::doBulkModification() {
+  BulkModificationWindow wnd(this, set, true);
+  if (wnd.ShowModal() == wxID_OK) {
+    // The actual modifying is done in this window's onOk function
+    return true;
+  }
+  return false;
+}
 
 bool CardListBase::parseUrl(String& url, vector<CardP>& out) {
   size_t j = out.size();
diff --git a/src/gui/control/card_list.hpp b/src/gui/control/card_list.hpp
index 8287c1d1..e9f96da9 100644
--- a/src/gui/control/card_list.hpp
+++ b/src/gui/control/card_list.hpp
@@ -81,9 +81,13 @@ public:
   bool doCopy() override;
   bool doCopyCardAndLinkedCards();
   bool doPaste() override;
-  bool doDelete() override;
+  bool doDelete() override;
+
+  // Try to perform a bulk operation, return success
   bool doAddCSV();
-  bool doAddJSON();
+  bool doAddJSON();
+
+  bool doBulkModification();
 
   // Look for cards inside some given data
   bool parseData(bool ignore_cards_from_own_card_list);
diff --git a/src/gui/set/cards_panel.cpp b/src/gui/set/cards_panel.cpp
index fc02c9ac..6763c4d7 100644
--- a/src/gui/set/cards_panel.cpp
+++ b/src/gui/set/cards_panel.cpp
@@ -138,6 +138,7 @@ CardsPanel::CardsPanel(Window* parent, int id)
     add_menu_item(menuCard, ID_CARD_REMOVE, "card_del", _MENU_("remove card")+_(" "), _HELP_("remove card"));
     add_menu_item(menuCard, ID_CARD_LINK, "card_link", _MENU_("link card") + _(" "), _HELP_("link card"));
     add_menu_item(menuCard, ID_CARD_AND_LINK_COPY, "card_copy", _MENU_("copy card and links") + _(" "), _HELP_("copy card and links"));
+    add_menu_item(menuCard, ID_CARD_BULK, "card_modify_multiple", _MENU_("bulk modify") + _(" "), _HELP_("bulk modify"));
     menuCard->AppendSeparator();
     auto menuRotate = new wxMenu();
       add_menu_item_tr(menuRotate, ID_CARD_ROTATE_0, "card_rotate_0", "rotate_0", wxITEM_CHECK);
@@ -451,6 +452,9 @@ void CardsPanel::onCommand(int id) {
     }
     case ID_CARD_AND_LINK_COPY:
       card_list->doCopyCardAndLinkedCards();
+      break;
+    case ID_CARD_BULK:
+      card_list->doBulkModification();
       break;
     case ID_CARD_ROTATE:
     case ID_CARD_ROTATE_0: case ID_CARD_ROTATE_90: case ID_CARD_ROTATE_180: case ID_CARD_ROTATE_270: {
diff --git a/src/util/window_id.hpp b/src/util/window_id.hpp
index 02bc6845..c8cc9099 100644
--- a/src/util/window_id.hpp
+++ b/src/util/window_id.hpp
@@ -115,7 +115,12 @@ enum ChildMenuID {
   ID_CARD_ADD_CSV_BROWSE,
   ID_CARD_ADD_JSON,
   ID_CARD_ADD_JSON_ARRAY,
-  ID_CARD_ADD_JSON_BROWSE,
+  ID_CARD_ADD_JSON_BROWSE,
+  ID_CARD_BULK,
+  ID_CARD_BULK_TYPE,
+  ID_CARD_BULK_FIELD,
+  ID_CARD_BULK_MODIFICATION,
+  ID_CARD_BULK_PREDICATE,
 
   // Keyword menu
   ID_KEYWORD_ADD = 6101,